Feat app adapters #63
Conversation
# Conflicts: # src/Utopia/Messaging/Adapters/Email.php # src/Utopia/Messaging/Adapters/Push.php # src/Utopia/Messaging/Adapters/SMS.php
|
@abnegate not sure if we should namespaces them as |
@eldadfux That works; just though of another option: what do you think about no nested namespace? Since they're not extending a base |
@abnegate I fear it will open a gateway for too much opinionated views and will start seeing to many types without a namespace which at some point could get out of hand. |
# Conflicts: # src/Utopia/Messaging/Adapter/SMS/GEOSMS.php # src/Utopia/Messaging/Adapter/SMS/GEOSMS/CallingCode.php # tests/Messaging/Adapter/Email/SendgridTest.php # tests/Messaging/Adapter/SMS/GEOSMS/CallingCodeTest.php # tests/Messaging/Adapter/SMS/GEOSMSTest.php
# Conflicts: # composer.json # composer.lock # src/Utopia/Messaging/Adapter/Push/APNS.php # src/Utopia/Messaging/Messages/Email.php # src/Utopia/Messaging/Messages/Push.php # src/Utopia/Messaging/Messages/SMS.php # tests/Messaging/Adapter/Email/EmailTest.php # tests/Messaging/Adapter/Email/MailgunTest.php # tests/Messaging/Adapter/Email/SendgridTest.php # tests/Messaging/Adapter/Push/APNSTest.php # tests/Messaging/Adapter/Push/FCMTest.php # tests/Messaging/Adapter/SMS/GEOSMS/CallingCodeTest.php # tests/Messaging/Adapter/SMS/GEOSMSTest.php # tests/Messaging/Adapter/SMS/Msg91Test.php # tests/Messaging/Adapter/SMS/SMSTest.php # tests/Messaging/Adapter/SMS/TelesignTest.php # tests/Messaging/Adapter/SMS/TelnyxTest.php # tests/Messaging/Adapter/SMS/TwilioTest.php # tests/Messaging/Adapter/SMS/VonageTest.php
What does this PR do?
Chatadapter baseTest Plan
Added discord test
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)